Conversation
|
For the third screenshot where there are no panels to display, could we add the "no repositories to analyse" text? I worry it's not clear why nothing is being displayed, and I worry people would think the page is broken. I'm not sure it's possible to hit this case since the API won't let you create a variant analysis with no scanned or skipped repos, but I appreciate the UI still needs to do something in this case. |
| "ts-jest", | ||
| { | ||
| tsconfig: "src/view/tsconfig.spec.json", | ||
| tsconfig: "<rootDir>/tsconfig.spec.json", |
There was a problem hiding this comment.
Just wondering why does this change need to happen for this PR? Could this be moved to a separate PR so it's not mixed in with unrelated changes?
|
The general idea of this PR looks great to me. Showing only the relevant tabs will make the view much clearer. |
This will hide the "Analyzed" panel when there are no scanned repos and it's completely empty. When all three panels are empty, this will also hide the search bar and filters, and will skip rendering anything for the panels.
koesie10
force-pushed
the
koesie10/hide-analyzed-when-failed
branch
from
c456fb0 to
96850e4
Compare
|
Thanks for the review!
I have updated the PR so we now show the warnings that are normally also shown. I have updated the screenshot in the PR description. I don't believe we can get into this state normally, but could it be that we get in this state when the processing job fails at some point? |
2 participants
This will hide the "Analyzed" panel when there are no scanned repos and it's completely empty.
When all three panels are empty, this will also hide the search bar and filters, and will skip rendering anything for the panels.
Before:
After:
Checklist
ready-for-doc-reviewlabel there.